linux-kernel - [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-6bbb614ec478961c7443086bdf7fd6784479c14a@git.kernel.org>
Date:	Sat, 28 Feb 2015 02:00:30 -0800
From:	tip-bot for Daniel Borkmann <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	jesse.brandeburg@...el.com, mingo@...nel.org,
	linux-kernel@...r.kernel.org, arjan@...ux.intel.com,
	daniel@...earbox.net, ast@...mgrid.com, bruce.w.allan@...el.com,
	hpa@...or.com, tglx@...utronix.de, bp@...e.de
Subject: [tip:x86/mm] x86/mm: Unexport set_memory_ro() and set_memory_rw()

Commit-ID:  6bbb614ec478961c7443086bdf7fd6784479c14a
Gitweb:     http://git.kernel.org/tip/6bbb614ec478961c7443086bdf7fd6784479c14a
Author:     Daniel Borkmann <daniel@...earbox.net>
AuthorDate: Fri, 27 Feb 2015 15:55:40 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Sat, 28 Feb 2015 10:41:59 +0100

x86/mm: Unexport set_memory_ro() and set_memory_rw()

This effectively unexports set_memory_ro() and set_memory_rw()
functions, and thus reverts:

  a03352d2c1dc ("x86: export set_memory_ro and set_memory_rw").

They have been introduced for debugging purposes in e1000e, but
no module user is in mainline kernel (anymore?) and we
explicitly do not want modules to use these functions, as they
i.e. protect eBPF (interpreted & JIT'ed) images from malicious
modifications or bugs.

Outside of eBPF scope, I believe also other set_memory_*()
functions should be unexported on x86 for modules.

Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
Acked-by: Alexei Starovoitov <ast@...mgrid.com>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Borislav Petkov <bp@...e.de>
Cc: Bruce Allan <bruce.w.allan@...el.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: davem@...emloft.net
Link: http://lkml.kernel.org/r/a064393a0a5d319eebde5c761cfd743132d4f213.1425040940.git.daniel@iogearbox.net
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/mm/pageattr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 536ea2f..81e8282 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -1654,13 +1654,11 @@ int set_memory_ro(unsigned long addr, int numpages)
 {
 	return change_page_attr_clear(&addr, numpages, __pgprot(_PAGE_RW), 0);
 }
-EXPORT_SYMBOL_GPL(set_memory_ro);
 
 int set_memory_rw(unsigned long addr, int numpages)
 {
 	return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_RW), 0);
 }
-EXPORT_SYMBOL_GPL(set_memory_rw);
 
 int set_memory_np(unsigned long addr, int numpages)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/