linux-kernel - Re: [PATCH] power: bq27x00_battery: add bq27510 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150228161215.GB886@earth>
Date:	Sat, 28 Feb 2015 17:12:15 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: bq27x00_battery: add bq27510 support

Hi Alexandre,

On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote:
> Hi,
> 
> On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote :
> > > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di)
> > >  {
> > >  	int cyct;
> > >  
> > > +
> > 
> > spurious newline.
> > 
> > > +	if (di->chip == BQ27510)
> > > +		cyct = bq27x00_read(di, BQ27510_REG_CYCT, false);
> > >  	cyct = bq27x00_read(di, BQ27x00_REG_CYCT, false);
> > 
> > missing else?
> > 
> 
> Indeed, I just sent v2. However, I'm not too happy with all that if/else
> layering in this driver. I'll try to rework it so that it scales better.

Thanks, that would be nice.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)