linux-kernel - [PATCH] rtc: abx805 depends on i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 28 Feb 2015 20:48:27 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Philippe De Muyter <phdm@...qel.be>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] rtc: abx805 depends on i2c

The recently added X805 rtc driver uses the i2c subsystem,
but has no Kconfig dependency, so it can result in a build
error when i2c is disabled:

drivers/rtc/rtc-abx805.c: In function 'abx805_read_multiple_regs':
drivers/rtc/rtc-abx805.c:55:2: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]

This adds the obvious dependency.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: 9033ab8ddd29 ("rtc: add rtc-abx805, a driver for the Abracon AB 1805 i2c rtc")

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 61ea2e3b4071..80ae27ffe8ea 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1083,6 +1083,7 @@ config RTC_DRV_AB8500
 
 config RTC_DRV_ABX805
 	tristate "Abracon AB X805 RTC"
+	depends on I2C
 	help
 	  Select this to enable support for the Abracon AB X805 RTC.
 	  AB X805 is the i2c flavour of the AB 18X5 family of ultra-low-power

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/