linux-kernel - Re: [PATCH v6 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425153626.24292.62.camel@x220>
Date:	Sat, 28 Feb 2015 21:00:26 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jaewon Kim <jaewon02.kim@...sung.com>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-input@...r.kernel.org,
	Inki Dae <inki.dae@...sung.com>,
	SangBae Lee <sangbae90.lee@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Sebastian Reichel <sre@...nel.org>,
	Beomho Seo <beomho.seo@...sung.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH v6 3/5] power: max77843_battery: Add Max77843 fuel gauge
 device driver

On Tue, 2015-02-24 at 10:29 +0900, Jaewon Kim wrote:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 994793d..555e436 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -212,6 +212,15 @@ config BATTERY_MAX17042
>  	  with MAX17042. This driver also supports max17047/50 chips which are
>  	  improved version of max17042.
>  
> +config BATTERY_MAX77843
> +	tristate "Maxim MAX77843 Fuel Gauge"
> +	depends on MFD_MAX77843
> +	help
> +	  This adds support for battery fuel gauge in Maxim MAX77843. It is
> +	  fuel-gauge for a lithium-ion batteries with a single cell and can be
> +	  found in portable devices. The MAX17040 is configured to operate with

Could MAX17040 be a copy/paste error?

> +	  a single lithium cell.
> +
>  config BATTERY_Z2
>  	tristate "Z2 battery driver"
>  	depends on I2C && MACH_ZIPIT2

[...]

> diff --git a/drivers/power/max77843_battery.c b/drivers/power/max77843_battery.c
> new file mode 100644
> index 0000000..0c59a16
> --- /dev/null
> +++ b/drivers/power/max77843_battery.c
> @@ -0,0 +1,286 @@
> +/*
> + * Fuel gauge driver for Maxim MAX77843
> + *
> + * Copyright (C) 2015 Samsung Electronics, Co., Ltd.
> + * Author: Beomho Seo <beomho.seo@...sung.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published bythe Free Software Foundation.
> + */

I did
    git grep "bythe Free" next-20150227

and it returned five hits. This would be the sixth.

Anyhow, this states that this file is licensed GPL v2.

[...]

> +MODULE_LICENSE("GPL");

So this should probably be
    MODULE_LICENSE("GPL v2");


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/