linux-kernel - Re: [PATCH] seccomp: switch to using asm-generic for seccomp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150228123656.538301ef@canb.auug.org.au>
Date:	Sat, 28 Feb 2015 12:36:56 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Kees Cook <keescook@...omium.org>
Cc:	akpm@...ux-foundation.org, linux-mips@...ux-mips.org,
	linux-sh@...r.kernel.org,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Paul Mackerras <paulus@...ba.org>, sparclinux@...r.kernel.org,
	linux-s390@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	Helge Deller <deller@....de>, x86@...nel.org,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	James Hogan <james.hogan@...tec.com>,
	linux-arm-kernel@...ts.infradead.org,
	Michal Simek <monstr@...str.eu>, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux390@...ibm.com, linuxppc-dev@...ts.ozlabs.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] seccomp: switch to using asm-generic for seccomp.h

Hi Kees,

On Fri, 27 Feb 2015 16:52:29 -0800 Kees Cook <keescook@...omium.org> wrote:
>
> diff --git a/arch/arm/include/asm/seccomp.h b/arch/arm/include/asm/seccomp.h
> index 52b156b341f5..66ca6a30bf5c 100644
> --- a/arch/arm/include/asm/seccomp.h
> +++ b/arch/arm/include/asm/seccomp.h
> @@ -1,11 +1 @@
> -#ifndef _ASM_ARM_SECCOMP_H
> -#define _ASM_ARM_SECCOMP_H
> -
> -#include <linux/unistd.h>
> -
> -#define __NR_seccomp_read __NR_read
> -#define __NR_seccomp_write __NR_write
> -#define __NR_seccomp_exit __NR_exit
> -#define __NR_seccomp_sigreturn __NR_rt_sigreturn
> -
> -#endif /* _ASM_ARM_SECCOMP_H */
> +#include <asm-generic/seccomp.h>

I think that these cases (where you replace the file by a stub that
just include <asm-generic/seccomp.h>) can be replaced by removing the
file completely and adding

generic-y = seccomp.h

to <ARCH>/include/asm/Kbuild

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped