linux-kernel - Re: [PATCH] perf tools: Fix pthread_attr_setaffinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150301161132.GA19425@gmail.com>
Date:	Sun, 1 Mar 2015 17:11:33 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>, Borislav Petkov <bp@...e.de>,
	David Ahern <david.ahern@...cle.com>,
	He Kuang <hekuang@...wei.com>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Kan Liang <kan.liang@...el.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Naohiro Aota <naota@...sp.net>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Wang Nan <wangnan0@...wei.com>,
	Yunlong Song <yunlong.song@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature
 detection on Ubuntu systems


* Jiri Olsa <jolsa@...hat.com> wrote:

> agreed, sry about that.. I'll try to clean it up while moving 
> features detection into tools/ as you suggested before

That would be nice!

> > --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> > +++ b/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> > @@ -5,10 +5,12 @@ int main(void)
> >  {
> >  	int ret = 0;
> >  	pthread_attr_t thread_attr;
> > +	cpu_set_t cpu_mask;
> >  
> >  	pthread_attr_init(&thread_attr);
> > -	/* don't care abt exact args, just the API itself in libpthread */
> > -	ret = pthread_attr_setaffinity_np(&thread_attr, 0, NULL);
> > +	CPU_ZERO(&cpu_mask);
> > +
> > +	ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cpu_mask), &cpu_mask);
> 
> I think Arnaldo got this one covered in perf/urgent already, but I 
> might have missed something..

Ok, I'll wait for his set of fixes.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/