lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 1 Mar 2015 17:52:36 +0100 From: Ingo Molnar <mingo@...nel.org> To: hpa@...or.com, adrian.hunter@...el.com, eranian@...gle.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, jolsa@...hat.com, acme@...hat.com Cc: linux-tip-commits@...r.kernel.org Subject: Re: [tip:perf/urgent] perf tools: Fix pthread_attr_setaffinity_np build error * tip-bot for Adrian Hunter <tipbot@...or.com> wrote: > --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c > +++ b/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c > @@ -5,10 +5,11 @@ int main(void) > { > int ret = 0; > pthread_attr_t thread_attr; > + cpu_set_t cs; > > pthread_attr_init(&thread_attr); > /* don't care abt exact args, just the API itself in libpthread */ > - ret = pthread_attr_setaffinity_np(&thread_attr, 0, NULL); > + ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cs), &cs); So I'm splitting hairs, as we never run these testcases, but I think a CPU_ZERO(&cs) is needed, as 'cs' might be uninitialized. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists