linux-kernel - Re: [PATCH] fanotify: Fix event filtering with FAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F279E6.90307@gmx.de>
Date:	Sun, 01 Mar 2015 03:31:02 +0100
From:	Lino Sanfilippo <LinoSanfilippo@....de>
To:	"Suzuki K. Poulose" <suzuki.poulose@....com>
CC:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	Eric Paris <eparis@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] fanotify: Fix event filtering with FAN_ONDIR set

Hi Suzuki,

On 27.02.2015 12:40, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@....com>
> 
> With FAN_ONDIR set, the user can end up getting events, which
> it hasn't marked. This was revealed with fanotify04 testcase
> failure on Linux-4.0-rc1, and is a regression from 3.19, revealed
> with commit (66ba93c0d7fe6: fanotify: don't set FAN_ONDIR implicitly
> on a marks ignored mask).
> 

> 
> Fix this by masking the outgoing events to the user, as we
> already take care of FAN_ONDIR and FAN_EVENT_ON_CHILD.
> 

thank you for fixing this. I tested your solution and it works, so you
can add Tested-by: Lino Sanfilippo <LinoSanfilippo@....de>.

Regards,
Lino




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/