linux-kernel - Re: [PATCH V2] Staging: dgnc: replace EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150301172607.GA30867@kroah.com>
Date:	Sun, 1 Mar 2015 09:26:07 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Matteo Semenzato <mattew8898@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Staging: dgnc: replace EXTRA_CFLAGS

On Sun, Mar 01, 2015 at 06:19:57PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@...il.com>
> 
> This patch removes EXTRA_CFLAGS from the Makefile and defines DDG_PART
> in dgnc_driver.h
> 
> Signed-off-by: Matteo Semenzato <mattew8898@...il.com>
> ---
>  drivers/staging/dgnc/Makefile      | 2 --
>  drivers/staging/dgnc/dgnc_driver.h | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index b69f7b6..995c874 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,5 +1,3 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> -
>  obj-$(CONFIG_DGNC) += dgnc.o
>  
>  dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index a8157eb..0b718a8 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -46,6 +46,7 @@
>  #define	PROCSTR		"dgnc"			/* /proc entries	 */
>  #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
>  #define	DRVSTR		"dgnc"			/* Driver name string	 */
> +#define DG_PART		"40002369_F"

Why do we need this define?

And why doesn't it use the same formatting as the other ones in this
list?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/