linux-kernel - Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for WM8650

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150301224959.4a106bfd@v1ron-s7>
Date:	Sun, 1 Mar 2015 22:49:59 +0300
From:	Roman Volkov <rvolkov@...os.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, Alexey Charkov <alchark@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] dts: vt8500: Add SDHC node to DTS file for
 WM8650

В Sun, 01 Mar 2015 20:59:13 +0300
Sergei Shtylyov <sergei.shtylyov@...entembedded.com> пишет:

> On 3/1/2015 7:06 PM, Roman Volkov wrote:
> 
> > Since WM8650 has the same 'WMT' SDHC controller as WM8505, and the
> > driver is already in the kernel, this node enables the controller
> > support for WM8650
> 
> > Signed-off-by: Roman Volkov <rvolkov@...os.org>
> > Reviewed-by: Alexey Charkov <alchark@...il.com>
> > ---
> >   arch/arm/boot/dts/wm8650.dtsi | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> 
> > diff --git a/arch/arm/boot/dts/wm8650.dtsi
> > b/arch/arm/boot/dts/wm8650.dtsi index b1c59a7..e12213d 100644
> > --- a/arch/arm/boot/dts/wm8650.dtsi
> > +++ b/arch/arm/boot/dts/wm8650.dtsi
> > @@ -187,6 +187,15 @@
> >   			interrupts = <43>;
> >   		};
> >
> > +		sdhc@...0a000 {
> 
>     According to the ePAPR standard, the device nodes should have
> generic names according to their functions, so this node should be
> named just "sd@...0a000".
> 
> WBR, Sergei
> 

Sergei,

Why not "sdmmc" or "sdhci" or "sdio" then? It would be great to name
nodes in same way, but there is no exact requirement in ePAPR v1.1
regarding SD/MMC controllers. Also, in Linux I don't see that someone
strictly follows this requirement. This renaming will affect driver,
since .compatible strings likely also need changing.

Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/