[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <370051425174554@web4m.yandex.ru>
Date: Sun, 01 Mar 2015 04:49:14 +0300
From: Евгений Поляков <zbr@...emap.net>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] w1: small cleanup in w1_family_notify()
Hi Dan
20.02.2015, 13:53, "Dan Carpenter" <dan.carpenter@...cle.com>:
> "sl->family->fops" and "fops" are the same thing, but it's nicer to use
> "fops" everywhere.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Looks good to me, thank you
Acked-by: Evgeniy Polyakov <zbr@...emap.net>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index 181f41c..59f932f 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -649,7 +649,7 @@ static int w1_family_notify(unsigned long action, struct w1_slave *sl)
> break;
> case BUS_NOTIFY_DEL_DEVICE:
> if (fops->remove_slave)
> - sl->family->fops->remove_slave(sl);
> + fops->remove_slave(sl);
> if (fops->groups)
> sysfs_remove_groups(&sl->dev.kobj, fops->groups);
> break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists