linux-kernel - Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a3014d48540bedb0ca333903934c40e.squirrel@codeaurora.org>
Date:	Sun, 1 Mar 2015 08:33:49 -0000
From:	"Gilad Broner" <gbroner@...eaurora.org>
To:	"Steven Rostedt" <rostedt@...dmis.org>
Cc:	"Gilad Broner" <gbroner@...eaurora.org>,
	james.bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	ygardi@...eaurora.org, draviv@...eaurora.org,
	"Lee Susman" <lsusman@...eaurora.org>,
	"Sujit Reddy Thumma" <sthumma@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...allels.com>,
	"Ingo Molnar" <mingo@...hat.com>
Subject: Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for
 debug

> If I understand the patch above, you basically have:
>
> 	if (....)
> 		goto out;
> 	else
> 		ret = ufshcd_resume();
> out:
>
> Wouldn't it be better to just reverse the above if condition?
>
> 	if (!...)
> 		ret = ufshcd_resume();
>
> That would be much less confusing.

It gives a logical place to put the comment, but I agree it will be
less confusing the other way.
I will fix this in the next patchset.

-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/