linux-kernel - Re: [PATCH] wil6210: increase cmd buffer size to avoid sscanf buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F41E4F.8090502@qca.qualcomm.com>
Date:	Mon, 2 Mar 2015 10:24:47 +0200
From:	Vladimir Kondratiev <QCA_vkondrat@....qualcomm.com>
To:	Colin King <colin.king@...onical.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	<linux-wireless@...r.kernel.org>, <wil6210@....qualcomm.com>,
	<netdev@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wil6210: increase cmd buffer size to avoid sscanf buffer
 overflow

On 03/01/2015 07:48 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> cppcheck detected a buffer overflow:
>
> [drivers/net/wireless/ath/wil6210/debugfs.c:634]: (error) Width 8
>    given in format string (no. 1) is larger than destination buffer
>    'cmd[8]', use %7s to prevent overflowing it.
>
> For the current %8s sscanf we require cmd to be 9 chars long
> so increase it by 1 byte to prevent the sscan overflow (rather
> than reduce the %8s specifier to %7s as cppcheck recommends).
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/net/wireless/ath/wil6210/debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
> index 45c3558e..29aab12 100644
> --- a/drivers/net/wireless/ath/wil6210/debugfs.c
> +++ b/drivers/net/wireless/ath/wil6210/debugfs.c
> @@ -618,7 +618,7 @@ static ssize_t wil_write_back(struct file *file, const char __user *buf,
>   	struct wil6210_priv *wil = file->private_data;
>   	int rc;
>   	char *kbuf = kmalloc(len + 1, GFP_KERNEL);
> -	char cmd[8];
> +	char cmd[9];
>   	int p1, p2, p3;
>
>   	if (!kbuf)
>
Thanks for finding this. Here is my
Acked-by: Vladimir Kondratiev <qca_vkondrat@....qualcomm.com>

Thanks, Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/