linux-kernel - Re: [PATCH] Staging: rtl8188eu: fix coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 11:46:57 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Matteo Semenzato <mattew8898@...il.com>,
	gregkh@...uxfoundation.org, oat.elena@...il.com,
	andriy.shevchenko@...ux.intel.com, hejianet@...il.com,
	tapaswenipathak@...il.com, cengelma@....at, abelmoyo.ab@...il.com,
	kristina.martsenko@...il.com, standby24x7@...il.com,
	sudipm.mukherjee@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: fix coding style errors

On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote:
> On 02/27/2015 10:44 AM, Matteo Semenzato wrote:
> >From: Matteo Semenzato <mattew8898@...il.com>
> >
> >This patch fixes the following errors:
> >ERROR: space prohibited before that ',' (ctx:WxW)
> >ERROR: space prohibited before that ',' (ctx:WxW)
> >ERROR: switch and case should be at the same indent
> >
> >Signed-off-by: Matteo Semenzato <mattew8898@...il.com>
> 
> I appreciate your efforts, but you are not improving the source.
> Running scripts/checkpatch.pl against your patch results in the
> following summary:
> 
> total: 60 errors, 32 warnings, 352 lines checked
> 
> You have fixed 60 errors, and introduced 60 new ones. :(

That's weird.  I only get the 32 warnings.  Those are all long line
warnings which were there in the original code as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/