linux-kernel - Re: [PATCH 0/3] Add ktd2692 Flash LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150302091530.GQ6539@valkosipuli.retiisi.org.uk>
Date:	Mon, 2 Mar 2015 11:15:30 +0200
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Ingi Kim <ingi2.kim@...sung.com>
Cc:	Jacek Anaszewski <j.anaszewski@...sung.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	cooloney@...il.com, rpurdie@...ys.net, treding@...dia.com,
	p.zabel@...gutronix.de, andrew@...n.ch, gregkh@...uxfoundation.org,
	florian.vaussard@...l.ch, arno@...isbad.org,
	kuninori.morimoto.gx@...esas.com, hytszk@...il.com,
	antonynpavlov@...il.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
	sw0312.kim@...sung.com, ideal.song@...sung.com
Subject: Re: [PATCH 0/3] Add ktd2692 Flash LED driver

H Ingi,

On Mon, Mar 02, 2015 at 04:14:39PM +0900, Ingi Kim wrote:
> Hi Jacek
> 
> On 2015년 02월 27일 17:42, Jacek Anaszewski wrote:
> > Hi Ingi,
> > 
> > On 02/27/2015 02:01 AM, Ingi Kim wrote:
> >> This patch supports KTD2692 flash LED driver
> >>
> >> Ingi Kim (3):
> >>    of: Add vendor prefix for Kinetic technologies
> >>    leds: ktd2692: add device tree bindings for ktd2692
> >>    leds: Add ktd2692 flash LED driver
> >>
> >>   .../devicetree/bindings/leds/leds-ktd2692.txt      |   19 ++
> >>   .../devicetree/bindings/vendor-prefixes.txt        |    1 +
> >>   drivers/leds/Kconfig                               |    8 +
> >>   drivers/leds/Makefile                              |    1 +
> >>   drivers/leds/leds-ktd2692.c                        |  245 ++++++++++++++++++++
> >>   5 files changed, 274 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
> >>   create mode 100644 drivers/leds/leds-ktd2692.c
> >>
> > 
> > In your device tree binding documentation there is torch-gpio mentioned,
> > but you seem not to use it in the driver.
> > 
> > We have already LED Flash class (/drivers/leds/led-class-flash.c) for
> > this type of devices, which handles both torch and flash modes
> > (flash_strobe sysfs attribute is provided for strobing the flash).
> > 
> > The reference drivers using LED Flash class are still pending [1], but I
> > think that at least leds-aat1290 driver is almost ready for merging.
> > It controls very similar device to yours.
> > 
> > Another advantage of using LED Flash class is that it has been designed
> > to be compatible with Video for Linux 2 subsystem, which will allow for registering LED Flash class devices as a V4L2 sub-devices.
> > 
> > Adding Sakari.
> > 
> 
> Ok, I'll check LED Flash class, and add torch-gpio

Many LED flash chips include a hardware pin for torch control but few really
need it. If you don't, i.e. you can implement the torch using the control bus
instead, I think I'd probably drop it from the chip's DT bindings.

I wonder what others think.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/