linux-kernel - Re: [PATCH V2] Staging: fbtft: fix coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150302092904.GD5386@mwanda>
Date:	Mon, 2 Mar 2015 12:29:04 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Matteo Semenzato <mattew8898@...il.com>
Cc:	thomas.petazzoni@...e-electrons.com, noralf@...nnes.org,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Staging: fbtft: fix coding style errors

On Sat, Feb 28, 2015 at 06:37:30PM +0100, Matteo Semenzato wrote:
>  static int hy28b_init_sequence[] = {
> -	-1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700,
> -	-1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000,
> -	-1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000,
> -	-1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000,
> -	-2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50,
> -	-1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50,
> -	-1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000,
> -	-1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700,
> -	-1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000,
> -	-1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000,
> -	-1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110,
> -	-1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000,
> -	-1,0x0021,0x0000,-2,100,-3 };
> +	-1, 0x00e7, 0x0010,
> +	-1, 0x0000, 0x0001,
> +	-1, 0x0001, 0x0100,
> +	-1, 0x0002, 0x0700,
> +	-1, 0x0003, 0x1030,
> +	-1, 0x0004, 0x0000,
> +	-1, 0x0008, 0x0207,
> +	-1, 0x0009, 0x0000,
> +	-1, 0x000a, 0x0000,
> +	-1, 0x000c, 0x0001,
> +	-1, 0x000d, 0x0000,
> +	-1, 0x000f, 0x0000,
> +	-1, 0x0010, 0x0000,
> +	-1, 0x0011, 0x0007,
> +	-1, 0x0012, 0x0000,
> +	-1, 0x0013, 0x0000,
> +	-2, 50,
> +	-1, 0x0010, 0x1590,
> +	-1, 0x0011, 0x0227,
> +	-2, 50,
> +	-1, 0x0012, 0x009c,
> +	-2, 50,
> +	-1, 0x0013, 0x1900,
> +	-1, 0x0029, 0x0023,
> +	-1, 0x002b, 0x000e,
> +	-2, 50,
> +	-1, 0x0020, 0x0000,
> +	-1, 0x0021, 0x0000,
> +	-2, 50,
> +	-1, 0x0050, 0x0000,
> +	-1, 0x0051, 0x00ef,
> +	-1, 0x0052, 0x0000,
> +	-1, 0x0053, 0x013f,
> +	-1, 0x0060, 0xa700,
> +	-1, 0x0061, 0x0001,
> +	-1, 0x006a, 0x0000,
> +	-1, 0x0080, 0x0000,
> +	-1, 0x0081, 0x0000,
> +	-1, 0x0082, 0x0000,
> +	-1, 0x0083, 0x0000,
> +	-1, 0x0084, 0x0000,
> +	-1, 0x0085, 0x0000,
> +	-1, 0x0090, 0x0010,
> +	-1, 0x0092, 0x0000,
> +	-1, 0x0093, 0x0003,
> +	-1, 0x0095, 0x0110,
> +	-1, 0x0097, 0x0000,
> +	-1, 0x0098, 0x0000,
> +	-1, 0x0007, 0x0133,
> +	-1, 0x0020, 0x0000,
> +	-1, 0x0021, 0x0000,
> +	-2, 100,
> +	-3
> +};

For some reason you put the line breaks at the negative numbers?  Why?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/