linux-kernel - Re: [PATCH 03/27] staging: lustre: Convert uses of "int rc = seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150302012206.GA2602@kroah.com>
Date:	Sun, 1 Mar 2015 17:22:06 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	HPDD-discuss@...ts.01.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 03/27] staging: lustre: Convert uses of "int rc =
 seq_printf(...)"

On Sat, Feb 21, 2015 at 06:53:30PM -0800, Joe Perches wrote:
> The seq_printf return value, because it's frequently misused,
> will eventually be converted to void.
> 
> See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
>      seq_has_overflowed() and make public")
> 
> Convert these uses to:
> 
> 	seq_printf(seq, ...);
> 
> 	return 0;
> 
> Done via cocci script:
> 
> @@
> struct seq_file *seq;
> int i;
> @@
> -	i = seq_printf(seq,
> +	seq_printf(seq,
> 		   ...);
> 	...
> -	return i;
> +	return 0;
> 
> @@
> struct seq_file *seq;
> int i;
> @@
> -	i = 0;
> -	i += seq_printf(seq,
> +	seq_printf(seq,
> 	           ...);
> 	...
> -	return i;
> +	return 0;
> 
> With some additional reformatting and typing post conversion
> to remove the now unnecessary "int i;" declaration.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> Cc: Oleg Drokin <oleg.drokin@...el.com>
> Cc: Andreas Dilger <andreas.dilger@...el.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  drivers/staging/lustre/lustre/fid/lproc_fid.c      | 23 +++---
>  drivers/staging/lustre/lustre/llite/lproc_llite.c  |  5 +-
>  drivers/staging/lustre/lustre/mdc/lproc_mdc.c      |  6 +-
>  drivers/staging/lustre/lustre/osc/lproc_osc.c      | 45 ++++++------
>  .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c    |  5 +-
>  drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c    | 82 +++++++++++-----------
>  6 files changed, 79 insertions(+), 87 deletions(-)

This patch fails to apply to my tree anymore :(

Can you refresh it against the staging-testing branch of staging.git and
resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/