linux-kernel - Re: [PATCH] ARM: at91: pm: fix SRAM allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 11:57:36 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	Nicolas FERRE <nicolas.ferre@...el.com>,
	Wenyou Yang <Wenyou.Yang@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: at91: pm: fix SRAM allocation

On 02/03/2015 at 18:50:27 +0800, Jean-Christophe PLAGNIOL-VILLARD wrote :
> 
> > On Mar 2, 2015, at 6:42 PM, Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote:
> > 
> > On some platforms, there are multiple SRAM nodes defined in the device tree but
> > some of them are disabled, leading to allocation failure. Try to find the first
> > enabled SRAM node and allocate from it.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > ---
> > arch/arm/mach-at91/pm.c | 20 +++++++++-----------
> > 1 file changed, 9 insertions(+), 11 deletions(-)
> > 
> > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> > index 5e34fb143309..97cc529b6fa0 100644
> > --- a/arch/arm/mach-at91/pm.c
> > +++ b/arch/arm/mach-at91/pm.c
> > @@ -272,35 +272,33 @@ static void __init at91_pm_sram_init(void)
> > 	struct device_node *node;
> > 	struct platform_device *pdev;
> 
> pdev not initialised at NULL

Indeed, I'll fix that. It doesn't really matter for now as all the
at91 DT have at least one sram node.

Wenyou, can you test it? If it works, I'll send v2.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/