linux-kernel - Re: [PATCH 1/4] crypto: caam: fix some compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F444C3.6020505@freescale.com>
Date:	Mon, 2 Mar 2015 13:08:51 +0200
From:	Horia Geantă <horia.geanta@...escale.com>
To:	<yanjiang.jin@...driver.com>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>
CC:	<kim.phillips@...escale.com>, <ruchika.gupta@...escale.com>,
	<cristian.stoica@...escale.com>, <NiteshNarayanLal@...escale.com>,
	<jinyanjiang@...il.com>, <linux-kernel@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 1/4] crypto: caam: fix some compile warnings

On 2/28/2015 8:00 AM, yanjiang.jin@...driver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@...driver.com>
> 
> This commit is to avoid the below warnings:
> 
> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning:
> 'dma_map_sg_chained' defined but not used [-Wunused-function]
>  static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
>             ^
> drivers/crypto/caam/sg_sw_sec4.h:104:12: warning:
> 'dma_unmap_sg_chained' defined but not used [-Wunused-function]
>  static int dma_unmap_sg_chained(struct device *dev,
>             ^
> 
> Signed-off-by: Yanjiang Jin <yanjiang.jin@...driver.com>

Reviewed-by: Horia Geanta <horia.geanta@...escale.com>

> ---
>  drivers/crypto/caam/sg_sw_sec4.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/caam/sg_sw_sec4.h b/drivers/crypto/caam/sg_sw_sec4.h
> index 3b91821..a6276eb 100644
> --- a/drivers/crypto/caam/sg_sw_sec4.h
> +++ b/drivers/crypto/caam/sg_sw_sec4.h
> @@ -85,7 +85,7 @@ static inline int sg_count(struct scatterlist *sg_list, int nbytes,
>  	return sg_nents;
>  }
>  
> -static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
> +static inline int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
>  			      unsigned int nents, enum dma_data_direction dir,
>  			      bool chained)
>  {
> @@ -101,9 +101,9 @@ static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
>  	return nents;
>  }
>  
> -static int dma_unmap_sg_chained(struct device *dev, struct scatterlist *sg,
> -				unsigned int nents, enum dma_data_direction dir,
> -				bool chained)
> +static inline int dma_unmap_sg_chained(struct device *dev,
> +				struct scatterlist *sg, unsigned int nents,
> +				enum dma_data_direction dir, bool chained)
>  {
>  	if (unlikely(chained)) {
>  		int i;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/