lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Mar 2015 19:31:02 +0800 From: Yakir Yang <ykk@...k-chips.com> To: Paul Bolle <pebolle@...cali.nl> CC: Liam Girdwood <lgirdwood@...il.com>, djkurtz@...omium.org, dianders@...omium.org, linux-rockchip@...ts.infradead.org, David Airlie <airlied@...ux.ie>, Philipp Zabel <p.zabel@...gutronix.de>, Russell King <rmk+kernel@....linux.org.uk>, Andy Yan <andy.yan@...k-chips.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Fabio Estevam <fabio.estevam@...escale.com>, dri-devel@...ts.freedesktop.org, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>, Lars-Peter Clausen <lars@...afoo.de>, Brian Austin <brian.austin@...rus.com>, Bard Liao <bardliao@...ltek.com>, Oder Chiou <oder_chiou@...ltek.com>, Max Filippov <jcmvbkbc@...il.com>, Axel Lin <axel.lin@...ics.com>, Arnd Bergmann <arnd@...db.de>, Jyri Sarha <jsarha@...com>, Sean Cross <xobs@...agi.com>, Ben Zhang <benzh@...omium.org>, linux-kernel@...r.kernel.org, alsa-devel@...a-project.org, mmind00@...glemail.com, marcheu@...omium.org, mark.yao@...k-chips.com Subject: Re: [PATCH v4 13/15] ASoC: codec/dw-hdmi-audio: add codec driver for dw hdmi audio 在 2015/3/2 17:15, Paul Bolle 写道: > On Sat, 2015-02-28 at 21:59 -0500, Yakir Yang wrote: >> --- /dev/null >> +++ b/sound/soc/codecs/dw-hdmi-audio.c >> @@ -0,0 +1,379 @@ >> +/* >> + * dw-hdmi-codec.c > Doesn't match the filename. Is this line needed? Thanks, this comment are good for read, and seems others codec driver also content this comment, so I think we can keep this comment. I will correct the file name it in next version. Thanks for you reply :) > >> + * DesignerWare ALSA SoC DAI driver for DW HDMI audio. >> + * Copyright (c) 2014, CORPORATION. All rights reserved. >> + * Authors: Yakir Yang <ykk@...k-chips.com> >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program. If not, see <http://www.gnu.org/licenses/>.* >> + * >> + */ > This states that the license is plain GPL v2. > > (Missing empty line here.) Okay, thanks, correct it in next version. Thanks :) >> +#include <linux/init.h> > [...] > >> +MODULE_LICENSE("GPL"); > So you probably want > MODULE_LICENSE("GPL v2"); > > here. Okay, thanks, correct it in next version. Thanks :) Yakir Yang Best regards. > > Paul Bolle > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists