linux-kernel - Re: [PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 14:06:52 +0100
From:	Jan Kasprzak <kas@...muni.cz>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Ameen Ali <ameenali023@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

Sergei Shtylyov wrote:
: Hello.
: 
: On 02/24/2015 10:52 PM, Ameen Ali wrote:
: 
: >avoid out-of-bounds-read by checking count before indexing.
: 
: >Signed-off-by: Ameen Ali <Ameenali023@...il.com>
: >---
: >  drivers/net/wan/cosa.c | 2 +-
: >  1 file changed, 1 insertion(+), 1 deletion(-)
: 
: >diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
: >index 83c39e2..5252e21 100644
: >--- a/drivers/net/wan/cosa.c
: >+++ b/drivers/net/wan/cosa.c
: >@@ -376,7 +376,7 @@ static int __init cosa_init(void)
: >  	}
: >  	for (i=0; i<MAX_CARDS; i++)
: >  		cosa_cards[i].num = -1;
: >-	for (i=0; io[i] != 0 && i < MAX_CARDS; i++)
: >+	for (i=0; (i < MAX_CARDS) && (io[i] != 0) ; i++)
: 
:    Parens you've added aren't necessary.

	Yes, but I am OK with both variants.

:    I suggest to add spaces after and before = in the first expression.

	In that case, also the upper for() cycle should be modified
to match this. I don't think this is necessary.

-Yenya

-- 
| Jan "Yenya" Kasprzak   <kas at {fi.muni.cz - work | yenya.net - private}> |
| New GPG 4096R/A45477D5 -- see http://www.fi.muni.cz/~kas/pgp-rollover.txt |
| http://www.fi.muni.cz/~kas/     Journal: http://www.fi.muni.cz/~kas/blog/ |
||| "New and improved" is only really improved if it also takes backwards |||
||| compatibility into account, rather than saying "now everybody must do |||
||| things the new and improved - and different - way"   --Linus Torvalds |||


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/