lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Mar 2015 14:42:01 +0100 From: Stefan Agner <stefan@...er.ch> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Shawn Guo <shawn.guo@...aro.org>, linus.walleij@...aro.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 On 2015-03-02 13:59, Uwe Kleine-König wrote: > Hello Shawn > > On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote: >> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote: >> > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs >> > the values in struct imx_pin_reg to be -1. This has been done in a >> > rather unorthodox way by setting the memory to 0xff using memset... >> > Use a proper for loop to initialize the whole array with -1. >> > >> > Signed-off-by: Stefan Agner <stefan@...er.ch> >> >> Acked-by: Shawn Guo <shawn.guo@...aro.org> > too late. This patch is part of 4.0-rc1 (4ff0f034e95d). This is not the same patch. The patch you are mentioning is actually fixing a bug introduce in the change where we set -1 for uninitialized pins. This patch is solving the weird assignment of the initial value... -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists