linux-kernel - Re: [PATCH] omap_l3_noc.c: remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150302160617.GB3756@atomide.com>
Date:	Mon, 2 Mar 2015 08:06:18 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Valentin Rothberg <Valentin.Rothberg@...6.fr>
Cc:	nm@...com, santosh.shilimkar@...com, peter.ujfalusi@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] omap_l3_noc.c: remove IRQF_DISABLED flag

* Valentin Rothberg <Valentin.Rothberg@...6.fr> [150302 06:04]:
> The IRQF_DISABLED flag is a NOOP and scheduled to be removed.  According
> to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
> disabled") running IRQ handlers with interrupts enabled can cause stack
> overflows when the interrupt line of the issuing device is still active.
> 
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@...6.fr>

Applying into omap-for-v4.1/l3 thanks.

Tony

>  drivers/bus/omap_l3_noc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
> index 029bc73..11f7982 100644
> --- a/drivers/bus/omap_l3_noc.c
> +++ b/drivers/bus/omap_l3_noc.c
> @@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev)
>  	 */
>  	l3->debug_irq = platform_get_irq(pdev, 0);
>  	ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
> -			       IRQF_DISABLED, "l3-dbg-irq", l3);
> +			       0x0, "l3-dbg-irq", l3);
>  	if (ret) {
>  		dev_err(l3->dev, "request_irq failed for %d\n",
>  			l3->debug_irq);
> @@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev)
>  
>  	l3->app_irq = platform_get_irq(pdev, 1);
>  	ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
> -			       IRQF_DISABLED, "l3-app-irq", l3);
> +			       0x0, "l3-app-irq", l3);
>  	if (ret)
>  		dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);
>  
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/