linux-kernel - Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F494EC.10406@ti.com>
Date:	Mon, 2 Mar 2015 10:50:52 -0600
From:	Suman Anna <s-anna@...com>
To:	Joe Perches <joe@...ches.com>
CC:	Ohad Ben-Cohen <ohad@...ery.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] remoteproc/ste: add blank lines after declarations

On 02/27/2015 05:26 PM, Joe Perches wrote:
> On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
>> Fix couple of checkpatch warnings of the type,
>> "WARNING: Missing a blank line after declarations"
> []
>> diff --git a/drivers/remoteproc/ste_modem_rproc.c b/drivers/remoteproc/ste_modem_rproc.c
> []
>> @@ -230,6 +229,7 @@ static int sproc_start(struct rproc *rproc)
>>  static int sproc_stop(struct rproc *rproc)
>>  {
>>  	struct sproc *sproc = rproc->priv;
>> +
>>  	sproc_dbg(sproc, "stop ste-modem\n");
> 
> You could probably delete this sproc_dbg
> statement too as it duplicates function tracing.

Thanks for the comment, I will leave that to be done in a different
cleanup patch.

regards
Suman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/