linux-kernel - Re: [V4 PATCH 2/2] ata: ahci_platform: Add ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D119F11E.132ED%suravee.suthikulpanit@amd.com>
Date:	Mon, 2 Mar 2015 16:52:17 +0000
From:	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
To:	Tejun Heo <tj@...nel.org>
CC:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"lv.zheng@...el.com" <lv.zheng@...el.com>,
	"hpa@...ux.intel.com" <hpa@...ux.intel.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"hanjun.guo@...aro.org" <hanjun.guo@...aro.org>,
	"al.stone@...aro.org" <al.stone@...aro.org>,
	"graeme.gregory@...aro.org" <graeme.gregory@...aro.org>,
	"Duran, Leo" <leo.duran@....com>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>
Subject: Re: [V4 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching



On 3/2/15, 10:41, "Tejun Heo" <tj@...nel.org> wrote:

>On Mon, Mar 02, 2015 at 02:27:20AM -0600, Suravee Suthikulpanit wrote:
>> This patch adds ACPI supports for AHCI platform driver, which uses _CLS
>> method to match the device.
>> 
>> The following is an example of ASL structure in DSDT for a SATA
>>controller,
>> which contains _CLS package to be matched by the ahci_platform driver:
>> 
>>   Device (AHC0) // AHCI Controller
>>   {
>>     Name(_HID, "AMDI0600")
>>     Name (_CCA, 1)
>>     Name (_CLS, Package (3)
>>     {
>>       0x01, // Base Class: Mass Storage
>>       0x06, // Sub-Class: serial ATA
>>       0x01, // Interface: AHCI
>>     })
>>     Name (_CRS, ResourceTemplate ()
>>     {
>>       Memory32Fixed (ReadWrite, 0xE0300000, 0x00010000)
>>       Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive,,,) {
>>387 }
>>     })
>>   }
>> 
>> Also, since ATA driver should not require PCI support for ATA_ACPI,
>> this patch removes dependency in the driver/ata/Kconfig.
>> 
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
>
>Looks good to me from the libata side.
>
> Acked-by: Tejun Heo <tj@...nel.org>
>
>Please let me now if this needs to go through libata.
>
>Thanks.
>
>-- 
>tejun

Thank you. I will let you know one the whole series is ready.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/