linux-kernel - Re: [PATCH] dmaengine: virt-dma: fix completion list manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F4D631.6020605@metafoo.de>
Date:	Mon, 02 Mar 2015 22:29:21 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Vinod Koul <vinod.koul@...el.com>
CC:	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: virt-dma: fix completion list manipulation

On 03/02/2015 10:19 PM, Robert Jarzmik wrote:
> diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
> index 3772032..2a3da22 100644
> --- a/drivers/dma/virt-dma.h
> +++ b/drivers/dma/virt-dma.h
> @@ -91,7 +91,7 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
>   	dma_cookie_complete(&vd->tx);
>   	dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
>   		 vd, cookie);
> -	list_add_tail(&vd->node, &vc->desc_completed);
> +	list_move_tail(&vd->node, &vc->desc_completed);

That will break all drivers which handle this currently correctly and remove 
the descriptor from any list before calling vchan_cookie_complete.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/