linux-kernel - RE: [PATCH char-misc] mei: bus: () can be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN3PR0301MB0897A163184BE96BFE07E12596100@BN3PR0301MB0897.namprd03.prod.outlook.com>
Date:	Mon, 2 Mar 2015 21:57:46 +0000
From:	Nick Meier <Nick.Meier@...rosoft.com>
To:	kbuild test robot <fengguang.wu@...el.com>,
	Tomas Winkler <tomas.winkler@...el.com>
CC:	"kbuild-all@...org" <kbuild-all@...org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"Haiyang Zhang" <haiyangz@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH char-misc] mei: bus: () can be static

Yes - the function should have been static.  This change correctly corrects the oversight.

thanks,

-Nick

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@...el.com] 
Sent: Sunday, March 1, 2015 8:49 PM
To: Tomas Winkler
Cc: kbuild-all@...org; Greg Kroah-Hartman; Nick Meier; KY Srinivasan; Haiyang Zhang; devel@...uxdriverproject.org; linux-kernel@...r.kernel.org
Subject: [PATCH char-misc] mei: bus: () can be static

drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---
 vmbus_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 526fa8b..8313e25 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -48,7 +48,7 @@ static struct completion probe_event;  static int irq;
 
 
-int hyperv_panic_event(struct notifier_block *nb,
+static int hyperv_panic_event(struct notifier_block *nb,
 			unsigned long event, void *ptr)
 {
 	struct pt_regs *regs;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/