linux-kernel - RE: [PATCH] ARM: at91: pm: fix SRAM allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 03:25:10 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@...osoft.com>
CC:	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: at91: pm: fix SRAM allocation

Hi Alexandre,

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@...e-electrons.com]
> Sent: 2015年3月2日 18:58
> To: Jean-Christophe PLAGNIOL-VILLARD
> Cc: Ferre, Nicolas; Yang, Wenyou; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH] ARM: at91: pm: fix SRAM allocation
> 
> On 02/03/2015 at 18:50:27 +0800, Jean-Christophe PLAGNIOL-VILLARD wrote :
> >
> > > On Mar 2, 2015, at 6:42 PM, Alexandre Belloni <alexandre.belloni@...e-
> electrons.com> wrote:
> > >
> > > On some platforms, there are multiple SRAM nodes defined in the
> > > device tree but some of them are disabled, leading to allocation
> > > failure. Try to find the first enabled SRAM node and allocate from it.
> > >
> > > Signed-off-by: Alexandre Belloni
> > > <alexandre.belloni@...e-electrons.com>
> > > ---
> > > arch/arm/mach-at91/pm.c | 20 +++++++++-----------
> > > 1 file changed, 9 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index
> > > 5e34fb143309..97cc529b6fa0 100644
> > > --- a/arch/arm/mach-at91/pm.c
> > > +++ b/arch/arm/mach-at91/pm.c
> > > @@ -272,35 +272,33 @@ static void __init at91_pm_sram_init(void)
> > > 	struct device_node *node;
> > > 	struct platform_device *pdev;
> >
> > pdev not initialised at NULL
> 
> Indeed, I'll fix that. It doesn't really matter for now as all the
> at91 DT have at least one sram node.
> 
> Wenyou, can you test it? If it works, I'll send v2.
It works. Thanks.

Tested it on the AT91SAM9G20EK, AT91SAM9G35EK and SAMA5D36EK board.

Tested-by: Wenyou Yang <wenyou.yang@...el.com>

> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com


Best Regards,
Wenyou Yang