linux-kernel - Re: [PATCH] ftrace: Fix comments about trace/ftrace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Mar 2015 23:06:09 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Hou Pengyang <houpengyang@...wei.com>
Cc:	<mingo@...hat.com>, <wangnan0@...wei.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: Fix comments about trace/ftrace.h

On Tue, 3 Mar 2015 10:38:19 +0800
Hou Pengyang <houpengyang@...wei.com> wrote:


> >> --- a/include/trace/ftrace.h
> >> +++ b/include/trace/ftrace.h
> >> @@ -1,7 +1,8 @@
> >>   /*
> >>    * Stage 1 of the trace events.
> >>    *
> >> - * Override the macros in <trace/trace_events.h> to include the following:
> >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to
> >
> > I agree that the comment needs updating, but not to this.
> > TRACE_INCLUDE(TRACE_INCLUDE_FILE) is not very descriptive. Because
> > nobody understand exactly what that is. Do you?
> >
> > Change it to:
> >
> >    Override the macros in the event tracepoint header ...
> >
> > And do that for the ones below too. This is more descriptive than just
> > describing what the code is literally doing.
> >
> > -- Steve
> >
> To be more descriptive, how about "Override the macros in the event 
> tracepoint header <trace/events/XXX.h> ..." ? since, tracepoint headers 
> have already been moved to trace/events/ .

That's fine with me too.


-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/