lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 03 Mar 2015 09:22:20 +0000
From:	Vladimir Murzin <vladimir.murzin@....com>
To:	Randy Dunlap <rdunlap@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"lauraa@...eaurora.org" <lauraa@...eaurora.org>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Will Deacon <Will.Deacon@....com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"arnd@...db.de" <arnd@...db.de>,
	Mark Rutland <Mark.Rutland@....com>,
	"ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>
Subject: Re: [RFC PATCH 1/4] mm: move memtest under /mm

On 03/03/15 01:52, Randy Dunlap wrote:
> On 03/02/15 06:55, Vladimir Murzin wrote:
>> There is nothing platform dependent in the core memtest code, so other platform
>> might benefit of this feature too.
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@....com>
>> ---
>>  arch/x86/Kconfig            |   11 ----
>>  arch/x86/include/asm/e820.h |    8 ---
>>  arch/x86/mm/Makefile        |    2 -
>>  arch/x86/mm/memtest.c       |  118 -------------------------------------------
>>  include/linux/memblock.h    |    8 +++
>>  lib/Kconfig.debug           |   11 ++++
>>  mm/Makefile                 |    1 +
>>  mm/memtest.c                |  118 +++++++++++++++++++++++++++++++++++++++++++
>>  8 files changed, 138 insertions(+), 139 deletions(-)
>>  delete mode 100644 arch/x86/mm/memtest.c
>>  create mode 100644 mm/memtest.c
> 
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index c5cefb3..8eb064fd 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1732,6 +1732,17 @@ config TEST_UDELAY
>>  
>>  	  If unsure, say N.
>>  
>> +config MEMTEST
>> +	bool "Memtest"
>> +	---help---
>> +	  This option adds a kernel parameter 'memtest', which allows memtest
>> +	  to be set.
>> +	        memtest=0, mean disabled; -- default
>> +	        memtest=1, mean do 1 test pattern;
>> +	        ...
>> +	        memtest=4, mean do 4 test patterns.
> 
> This sort of implies a max of 4 test patterns, but it seems to be 17
> if I counted correctly, so if someone wants to test all of the possible
> 'memtest' patterns, they would need to use 'memtest=17', is that correct?
> 

Yes, that correct. Additional patterns were introduced since 63823126
"x86: memtest: add additional (regular) test patterns", but looks like
Kconfig was not updated that time. Do you want me to fold updates for
that info or make a separate patch?

Thanks
Vladimir

> 
>> +	  If you are unsure how to answer this question, answer N.
> 
> Thanks,
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists