linux-kernel - Re: [RFC 1/3] hugetlbfs: add reserved mount fields to subpool structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Mar 2015 17:20:51 -0800
From:	Mike Kravetz <mike.kravetz@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Nadia Yvette Chambers <nyc@...omorphy.com>,
	Aneesh Kumar <aneesh.kumar@...ux.vnet.ibm.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [RFC 1/3] hugetlbfs: add reserved mount fields to subpool structure

On 03/02/2015 03:10 PM, Andrew Morton wrote:
> On Fri, 27 Feb 2015 14:58:10 -0800 Mike Kravetz <mike.kravetz@...cle.com> wrote:
>
>> Add a boolean to the subpool structure to indicate that the pages for
>> subpool have been reserved.  The hstate pointer in the subpool is
>> convienient to have when it comes time to unreserve the pages.
>> subool_reserved() is a handy way to check if reserved and take into
>> account a NULL subpool.
>>
>> ...
>>
>> @@ -38,6 +40,10 @@ extern int hugetlb_max_hstate __read_mostly;
>>   #define for_each_hstate(h) \
>>   	for ((h) = hstates; (h) < &hstates[hugetlb_max_hstate]; (h)++)
>>
>> +static inline bool subpool_reserved(struct hugepage_subpool *spool)
>> +{
>> +	return spool && spool->reserved;
>> +}
>
> "subpool_reserved" is not a good identifier.
>
>>   struct hugepage_subpool *hugepage_new_subpool(long nr_blocks);
>>   void hugepage_put_subpool(struct hugepage_subpool *spool);
>
> See what they did?

Got it. Thanks. hugepage_subpool_reserved

-- 
Mike Kravetz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/