linux-kernel - Re: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 12:16:57 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers

On 03/03/2015 09:52 AM, Maxime Ripard wrote:
> On Mon, Jan 26, 2015 at 03:35:41PM +0100, Maxime Ripard wrote:
>>>> +static int sun5i_rate_cb_clksrc(struct notifier_block *nb,
>>>> +				unsigned long event, void *data)
>>>> +{
>>>> +	struct clk_notifier_data *ndata = data;
>>>> +	struct sun5i_timer *timer = to_sun5i_timer(nb);
>>>> +	struct sun5i_timer_clksrc *cs = container_of(timer,
>>>> +						     struct sun5i_timer_clksrc, timer);
>>>> +
>>>> +	switch (event) {
>>>> +	case PRE_RATE_CHANGE:
>>>> +		clocksource_unregister(&cs->clksrc);
>>>> +		break;
>>>> +
>>>> +	case POST_RATE_CHANGE:
>>>> +		clocksource_register_hz(&cs->clksrc, ndata->new_rate);
>>>> +		break;
>>>
>>> Why clocksource_unregister couldn't be in the POST_RATE_CHANGE ?
>>
>> Wouldn't that leave a (small, I agree) window where the timer would
>> run at a rate different to the one it has been registered with?
>
> Ping?

Hi Maxime,

except I missed something, there were a couple of comments and I was 
waiting a V3.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/