linux-kernel - Re: [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <13977718.vr52PylqCh@amdc1032>
Date:	Tue, 03 Mar 2015 12:28:17 +0100
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Kukjin Kim <kgene@...nel.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	stable@...r.kernel.org, Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4


Hi Kukjin,

It has been a month since this regression fix was originally posted:
	https://lkml.org/lkml/2015/2/3/481

Could you please review/apply it?  Thank you.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

On Monday, February 23, 2015 05:25:48 PM Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, February 18, 2015 11:45:25 AM Krzysztof Kozlowski wrote:
> > On Exynos4412 boards (Trats2, Odroid U3) after enabling L2 cache in
> > 56b60b8bce4a ("ARM: 8265/1: dts: exynos4: Add nodes for L2 cache
> > controller") the second suspend to RAM failed. First suspend worked fine
> > but the next one hang just after powering down of secondary CPUs (system
> > consumed energy as it would be running but was not responsive).
> > 
> > The issue was caused by enabling delayed reset assertion for CPU0 just
> > after issuing power down of cores. This was introduced for Exynos4 in
> > 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off").
> > 
> > The whole behavior is not well documented but after checking with vendor
> > code this should be done like this (on Exynos4):
> > 1. Enable delayed reset assertion when system is running (for all CPUs).
> > 2. Disable delayed reset assertion before suspending the system.
> >    This can be done after powering off secondary CPUs.
> > 3. Re-enable the delayed reset assertion when system is resumed.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > Fixes: 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off")
> > Cc: <stable@...r.kernel.org>
> 
> It turned out that this patch is also needed to fix cpuidle AFTR mode
> hang on Trats2.
> 
> Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/