linux-kernel - Re: [PATCH] phy: ti-pipe3: Simplify ti_pipe3_dpll_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 14:57:56 +0200
From:	Roger Quadros <rogerq@...com>
To:	Axel Lin <axel.lin@...ics.com>,
	Kishon Vijay Abraham I <kishon@...com>
CC:	Vignesh R <vigneshr@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: ti-pipe3: Simplify ti_pipe3_dpll_wait_lock implementation

On 03/03/15 14:04, Axel Lin wrote:
> Code simplification. No functional change.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger

> ---
>  drivers/phy/phy-ti-pipe3.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
> index 95c88f9..ed72b0d 100644
> --- a/drivers/phy/phy-ti-pipe3.c
> +++ b/drivers/phy/phy-ti-pipe3.c
> @@ -165,15 +165,11 @@ static int ti_pipe3_dpll_wait_lock(struct ti_pipe3 *phy)
>  		cpu_relax();
>  		val = ti_pipe3_readl(phy->pll_ctrl_base, PLL_STATUS);
>  		if (val & PLL_LOCK)
> -			break;
> +			return 0;
>  	} while (!time_after(jiffies, timeout));
>  
> -	if (!(val & PLL_LOCK)) {
> -		dev_err(phy->dev, "DPLL failed to lock\n");
> -		return -EBUSY;
> -	}
> -
> -	return 0;
> +	dev_err(phy->dev, "DPLL failed to lock\n");
> +	return -EBUSY;
>  }
>  
>  static int ti_pipe3_dpll_program(struct ti_pipe3 *phy)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/