lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Mar 2015 17:28:16 +0100 From: Christian Ruppert <christian.ruppert@...tech.com> To: Alexey Brodkin <Alexey.Brodkin@...opsys.com>, linux-i2c@...r.kernel.org CC: linux-kernel@...r.kernel.org, Vineet Gupta <Vineet.Gupta1@...opsys.com>, Christian Ruppert <christian.ruppert@...lis.com>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Wolfram Sang <wsa@...-dreams.de> Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER On 2015-03-03 16:27, Alexey Brodkin wrote: > There's no point in printing error message if platform_get_irq() > returns -EPROBE_DEFER because probe deferring subsystem already outputs > message in bootlog like this: > --->8--- > platform e001d000.i2c: Driver i2c_designware requests probe deferral > --->8--- > > Moreover in case of probe deferral following message may mislead user: > --->8--- > i2c_designware e001d000.i2c: no irq resource? > --->8--- > even though it's expected that platform_get_irq() may return > -EPROBE_DEFER. > > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com> > Cc: Vineet Gupta <vgupta@...opsys.com> > Cc: Christian Ruppert <christian.ruppert@...lis.com> > Cc: Mika Westerberg <mika.westerberg@...ux.intel.com> > Cc: Wolfram Sang <wsa@...-dreams.de> > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index c270f5f..01c1b17 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -144,7 +144,8 @@ static int dw_i2c_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "no irq resource?\n"); > + if (irq != -EPROBE_DEFER) > + dev_err(&pdev->dev, "no irq resource?\n"); Presented like this I wonder if this merits being a dev_err at all. Wouldn't dev_dbg be more adequate? This might remove the need for the condition and also avoid bothering everyone if something in the platform device structures or device tree is not right. > return irq; /* -ENXIO */ > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists