linux-kernel - Re: [PATCH] Staging: fbtft: move externs to header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 20:04:10 +0100
From:	Noralf Trønnes <noralf@...nnes.org>
To:	Drew Fustini <pdp7pdp7@...il.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: fbtft: move externs to header file


Den 03.03.2015 11:19, skrev Drew Fustini:
> Move extern declartions from fbtft-core.c to fbtft header file. This resovles
> the warning from checkpatch.pl that "externs should be avoided in .c files".
>
> Signed-off-by: Drew Fustini <pdp7pdp7@...il.com>
> ---
>   drivers/staging/fbtft/fbtft-core.c | 5 -----
>   drivers/staging/fbtft/fbtft.h      | 7 +++++++
>   2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index ac4287f..3422faf 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -42,11 +42,6 @@
>   
>   #include "fbtft.h"
>   
> -extern void fbtft_sysfs_init(struct fbtft_par *par);
> -extern void fbtft_sysfs_exit(struct fbtft_par *par);
> -extern void fbtft_expand_debug_value(unsigned long *debug);
> -extern int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves,
> -						const char *str, int size);
>   
>   static unsigned long debug;
>   module_param(debug, ulong, 0);
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 0dbf3f9..9e729e5 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -277,6 +277,13 @@ extern int fbtft_init_display(struct fbtft_par *par);
>   extern int fbtft_probe_common(struct fbtft_display *display,
>   	struct spi_device *sdev, struct platform_device *pdev);
>   extern int fbtft_remove_common(struct device *dev, struct fb_info *info);
> +extern void fbtft_sysfs_init(struct fbtft_par *par);
> +extern void fbtft_sysfs_exit(struct fbtft_par *par);
> +extern void fbtft_expand_debug_value(unsigned long *debug);
> +extern int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves,
> +						const char *str, int size);
> +
> +
>   
>   /* fbtft-io.c */
>   extern int fbtft_write_spi(struct fbtft_par *par, void *buf, size_t len);

These functions are defined in fbtft-sysfs.c and internal to the fbtft 
module.
I think it's better to put them in an 'internal.h' file.
The fbtft.h file will eventually live in include/linux/fbtft.h or 
something like that.


Noralf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/