linux-kernel - Re: [PATCH] gianfar: Reduce logging noise seen due to phy polling if link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 14:37:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	netdev@...r.kernel.org, claudiu.manoil@...escale.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gianfar: Reduce logging noise seen due to phy polling
 if link is down

From: Guenter Roeck <linux@...ck-us.net>
Date: Mon,  2 Mar 2015 12:03:27 -0800

> Commit 6ce29b0e2a04 ("gianfar: Avoid unnecessary reg accesses in adjust_link()")
> eliminates unnecessary calls to adjust_link for phy devices which don't support
> interrupts and need polling. As part of that work, the 'new_state' local flag,
> which was used to reduce logging noise on the console, was eliminated.
> 
> Unfortunately, that means that a 'Link is Down' log message will now be
> issued continuously if a link is configured as UP, the link state is down,
> and the associated phy requires polling. This occurs because priv->oldduplex
> is -1 in this case, which always differs from phydev->duplex. In addition,
> phydev->speed may also differ from priv->oldspeed.  gfar_update_link_state()
> is therefore called each time a phy is polled, even if the link state did not
> change.
> 
> Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/