linux-kernel - Re: [PATCH v3 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150304160656.GB25087@mail.corp.redhat.com>
Date:	Wed, 4 Mar 2015 11:06:56 -0500
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Nikolai Kondrashov <spbnick@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	DIGImend-devel <DIGImend-devel@...ts.sourceforge.net>
Subject: Re: [PATCH v3 2/6] HID: uclogic: merge hid-huion driver in
 hid-uclogic

On Mar 04 2015 or thereabouts, Jiri Kosina wrote:
> On Tue, 3 Mar 2015, Benjamin Tissoires wrote:
> 
> > From: Nikolai Kondrashov <Nikolai.Kondrashov@...hat.com>
> > 
> > Merge the hid-huion driver into hid-uclogic as all the devices supported
> > by hid-huion are in fact UC-Logic devices.
> > 
> > Signed-off-by: Nikolai Kondrashov <Nikolai.Kondrashov@...hat.com>
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > ---
> > 
> > no changes in v3
> > no changes in v2
> > 
> >  drivers/hid/Kconfig       |   8 +-
> >  drivers/hid/Makefile      |   1 -
> >  drivers/hid/hid-huion.c   | 290 ----------------------------------------------
> >  drivers/hid/hid-uclogic.c | 229 +++++++++++++++++++++++++++++++++++-
> >  4 files changed, 229 insertions(+), 299 deletions(-)
> >  delete mode 100644 drivers/hid/hid-huion.c
> > 
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 152b006..8a55fd7 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -286,12 +286,6 @@ config HID_GT683R
> >  	Currently the following devices are know to be supported:
> >  	  - MSI GT683R
> >  
> > -config HID_HUION
> > -	tristate "Huion tablets"
> > -	depends on USB_HID
> > -	---help---
> > -	Support for Huion 580 tablet.
> > -
> 
> The dependency on USB_HID was there actually on purpose, as the huion 
> driver contained quite some USB-isms. Those now got merged to uclogic, but 
> uclogic doesn't have USB_HID dependency.

Oops, my bad.

> 
> Could you guys please sort this out?

Sure, I'll send a fix ASAP.

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/