linux-kernel - Re: [PATCH 1/3] arm64: Don't use is_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150304164701.GY28951@e104818-lin.cambridge.arm.com>
Date:	Wed, 4 Mar 2015 16:47:02 +0000
From:	Catalin Marinas <catalin.marinas@....com>
To:	Laura Abbott <lauraa@...eaurora.org>
Cc:	Will Deacon <will.deacon@....com>,
	Kees Cook <keescook@...omium.org>,
	Russell King <linux@....linux.org.uk>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] arm64: Don't use is_module_addr in setting page
 attributes

On Wed, Feb 25, 2015 at 02:14:55PM -0800, Laura Abbott wrote:
> 
> The set_memory_* functions currently only support module
> addresses. The addresses are validated using is_module_addr.
> That function is special though and relies on internal state
> in the module subsystem to work properly. At the time of
> module initialization and calling set_memory_*, it's too early
> for is_module_addr to work properly so it always returns
> false. Rather than be subject to the whims of the module state,
> just bounds check against the module virtual address range.
> 
> Signed-off-by: Laura Abbott <lauraa@...eaurora.org>

Not sure which tree this would be merged through, so:

Acked-by: Catalin Marinas <catalin.marinas@....com>

I can pick up the arm64 patch and the module.c one with Rusty's ack (as
for the arm one, I think it could go in via rmk's patch system).

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/