linux-kernel - Re: select on undefined THERMAL_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150304174623.GA14216@e104805>
Date:	Wed, 4 Mar 2015 17:46:24 +0000
From:	Javi Merino <javi.merino@....com>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	"rui.zhang@...el.com" <rui.zhang@...el.com>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Andreas Ruprecht <rupran@...server.de>,
	Paul Bolle <pebolle@...cali.nl>
Subject: Re: select on undefined THERMAL_POWER_ACTOR

Hi Valentin,

On Wed, Mar 04, 2015 at 01:19:25PM +0000, Valentin Rothberg wrote:
> your commit 8754d5115693 ("thermal: introduce the Power Allocator
> governor") is included in today's linux-next tree (i.e.,
> next-20150304).
> 
> This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
> However, THERMAL_POWER_ACTOR is not defined so that this select is a
> NOOP.
> 
> @@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
>         help
>           Enable this to let the user space manage the platform thermals.
> 
> +config THERMAL_GOV_POWER_ALLOCATOR
> +       bool "Power allocator thermal governor"
> +       select THERMAL_POWER_ACTOR
> 
> Is there a patch queued somewhere that adds this Kconfig symbol?

No there isn't, it's a leftover from a previous version of the
patches.  I'll send a patch to remove it.

Thanks for reporting it!
Javi

>                                                                   I
> detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (undertaker.cs.fau.de).
> 
> Kind regards,
>  Valentin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/