linux-kernel - Re: [PATCH v5 8/9] rtc: st: add new driver for ST's LPC RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425497072.2090.4.camel@tiscali.nl>
Date:	Wed, 04 Mar 2015 20:24:32 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...inux.com, rtc-linux@...glegroups.com, wim@...ana.be,
	linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
	linux@...ck-us.net, david.paris@...com, a.zummo@...ertech.it
Subject: Re: [PATCH v5 8/9] rtc: st: add new driver for ST's LPC RTC

Lee Jones schreef op wo 04-03-2015 om 18:06 [+0000]:
> --- /dev/null
> +++ b/drivers/rtc/rtc-st-lpc.c
> @@ -0,0 +1,354 @@
> +/*
> + * rtc-st-lpc.c - ST's LPC RTC, powered by the Low Power Timer
> + *
> + * Copyright (C) 2014 STMicroelectronics Limited
> + *
> + * Author: David Paris <david.paris@...com> for STMicroelectronics
> + *         Lee Jones <lee.jones@...aro.org> for STMicroelectronics
> + *
> + * Based on the original driver written by Stuart Menefy.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public Licence
> + * as published by the Free Software Foundation; either version
> + * 2 of the Licence, or (at your option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPLv2");

This will taint the kernel at module load, won't it? You probably meant
"GPL v2", but only
    MODULE_LICENSE("GPL");

correctly matches the license in the comment at the top of this file. 

(I assume I missed all this when looking at the v4 series.)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/