[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150304193650.GA587@fuloong-minipc.musicnaut.iki.fi>
Date: Wed, 4 Mar 2015 21:36:50 +0200
From: Aaro Koskinen <aaro.koskinen@....fi>
To: Pavel Machek <pavel@....cz>
Cc: Sebastian Reichel <sre@...nel.org>,
Peter Ujfalusi <peter.ujfalusi@...com>,
Kai Vehmanen <kvcontact@...ignal.fi>,
Pali Rohar <pali.rohar@...il.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-api@...r.kernel.org
Subject: Re: [PATCHv2 0/2] N900 Modem Speech Support
On Wed, Mar 04, 2015 at 08:24:19PM +0100, Pavel Machek wrote:
> @@ -1239,8 +1234,8 @@ static long cs_char_ioctl(struct file *file, unsigned int cmd,
>
> if (copy_to_user((void __user *)arg, &ifver, sizeof(ifver)))
> r = -EFAULT;
> - break;
> }
> + break;
> case CS_CONFIG_BUFS: {
> struct cs_buffer_config buf_cfg;
>
> @@ -1249,8 +1244,8 @@ static long cs_char_ioctl(struct file *file, unsigned int cmd,
> r = -EFAULT;
> else
> r = cs_hsi_buf_config(csdata->hi, &buf_cfg);
> - break;
> }
> + break;
I think having the break inside the block is more readable.
Now the indendation is mess.
A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists