linux-kernel - Re: [PATCH] stmmac: check IRQ availability early on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150304.154412.1886796464281085513.davem@davemloft.net>
Date:	Wed, 04 Mar 2015 15:44:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Alexey.Brodkin@...opsys.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vineet.Gupta1@...opsys.com, andriy.shevchenko@...ux.intel.com,
	peppe.cavallaro@...com, sonic.zhang@...log.com
Subject: Re: [PATCH] stmmac: check IRQ availability early on probe

From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Date: Tue,  3 Mar 2015 13:46:44 +0300

> Currently we're getting IRQs after lots of resources are already
> allocated:
>  * netdev
>  * clocks
>  * MDIO bus
> Also HW gets initialized by the time when checking IRQs as well.
> 
> Now there's a possibility for master interrupt controller to be not
> probed yet. This will lead to exit from GMAC probe routine with "-
> EPROBE_DEFER" and so deferred probe will hapen later on.
> 
> But since we exited the first GMAC probe without release of all
> allocated resources there could be conflicts on subsequent probes.
> 
> For example this is what happens for me:
 ...
> Essential fix is to check for IRQs availability as early as possible and
> then safely go to deferred probe if IRQs are not there yet.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/