linux-kernel - Re: [PATCH] ihex: restore missing default in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150304141815.e740456b5e386c2357f89194@linux-foundation.org>
Date:	Wed, 4 Mar 2015 14:18:15 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] ihex: restore missing default in switch statement

On Wed,  4 Mar 2015 22:24:10 +0800 Nicolas Iooss <nicolas.iooss_linux@....org> wrote:

> Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes
> the "default:" statement in the switch block, making the "return
> usage();" line dead code and ihex2fw silently ignoring unknown options.
> Restore this statement.
> 
> This bug was found by building with HOSTCC=clang and adding
> -Wunreachable-code-return to HOSTCFLAGS.
> 
> ...
>
> --- a/firmware/ihex2fw.c
> +++ b/firmware/ihex2fw.c
> @@ -86,6 +86,7 @@ int main(int argc, char **argv)
>  		case 'j':
>  			include_jump = 1;
>  			break;
> +		default:
>  			return usage();
>  		}
>  	}

whee.  So if there's userspace out there which is passing bad options
to ihex2fw, this fix will break it.

Oh well, I expect we'll survive.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/