linux-kernel - Re: [PATCH] mm: fix anon_vma->degree underflow in anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1503032153510.12253@chino.kir.corp.google.com>
Date:	Tue, 3 Mar 2015 21:54:38 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Michal Hocko <mhocko@...e.cz>
cc:	Leon Yu <chianglungyu@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konstantin Khlebnikov <koct9i@...il.com>,
	Rik van Riel <riel@...hat.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] mm: fix anon_vma->degree underflow in anon_vma endless
 growing prevention

On Tue, 3 Mar 2015, Michal Hocko wrote:

> I think we can safely remove the following code as well, because it is
> anon_vma_clone which is responsible to do all the cleanups.
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 943c6ad18b1d..06a6076c92e5 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -774,10 +774,8 @@ again:			remove_next = 1 + (end > next->vm_end);
>  
>  			importer->anon_vma = exporter->anon_vma;
>  			error = anon_vma_clone(importer, exporter);
> -			if (error) {
> -				importer->anon_vma = NULL;
> +			if (error)
>  				return error;
> -			}
>  		}
>  	}
>  

When Michal proposes this on top of -mm, feel free to add my

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/