linux-kernel - Re: [PATCH 1/2] tracing: remove ftrace:function TRACE_EVENT_FL_USE_CALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+tJtZmDfqC5rpDnnd-FSPrPJ8tTwMywR0BswOnjvYKhA@mail.gmail.com>
Date:	Tue, 3 Mar 2015 23:17:30 -0800
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>, wangnan0@...wei.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] tracing: remove ftrace:function TRACE_EVENT_FL_USE_CALL_FILTER
 flag

On Mon, Mar 2, 2015 at 11:21 PM, He Kuang <hekuang@...wei.com> wrote:
> TRACE_EVENT_FL_USE_CALL_FILTER flag in ftrace:functon event can be
> removed. This flag was first introduced in commit
> f306cc82a93d ("tracing: Update event filters for multibuffer").
>
> Now, the only place uses this flag is ftrace:function, but the filter of
> ftrace:function has a different code path with events/syscalls and
> events/tracepoints. It uses ftrace_filter_write() and perf's
> ftrace_profile_set_filter() to set the filter, the functionality of file
> 'tracing/events/ftrace/function/filter' is bypassed in function
> init_pred(), in which case, neither call->filter nor file->filter is
> used.
>
> So we can safely remove TRACE_EVENT_FL_USE_CALL_FILTER flag from
> ftrace:function events.

every time I looked at this piece of code was wondering
about the same. So intent definitely looks good to me.
Thanks for cleaning it up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/