linux-kernel - Re: [RFC PATCH] vfs: Use 12:20 bit major:minor in stat everywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150304014731.GW29656@ZenIV.linux.org.uk>
Date:	Wed, 4 Mar 2015 01:47:32 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Gwendal Grignou <gwendal@...gle.com>
Cc:	Daniel Ehrenberg <dehrenberg@...gle.com>,
	linux-fsdevel@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Gwendal Grignou <gwendal@...omium.org>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Subject: Re: [RFC PATCH] vfs: Use 12:20 bit major:minor in stat everywhere

On Tue, Mar 03, 2015 at 05:37:31PM -0800, Gwendal Grignou wrote:
> At least, to base the device format on whether we are running on a 32
> bit or 64 bit architecture does not make sense.

Yes, it does.  Note that on 32bit ones stat64(2) *will* return an arbitrary
value.  On 64bit ones stat(2) will.

> If a tool calling stat(2) can not handle 12 bit major/20 bits minor,
> it would already break or about to break when running on a 64 bit
> machine.
> 
> Regarding SCSI, the 17th disk will use SCSI_DISK1_MAJOR (65). Only the
> 257th disk will use the first scsi major (8) again and need a  minor
> greater than 256. (see sd_major() in drivers/scsi/sd.c for details).

*nod*

It's been years since I last looked at sd.c, TBH...

Said that, with NFS it's definitely a minor per superblock, and it's not the
only set_anon_super() user.  Having a bunch of filesystems mounted over NFS
will suffice...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/