linux-kernel - Re: [PATCH 1/3] crypto: caam: fix some compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Mar 2015 11:03:28 +0200
From:	Cristian Stoica <cristian.stoica@...escale.com>
To:	yjin <yanjiang.jin@...driver.com>,
	Kim Phillips <kim.phillips@...escale.com>
CC:	<horia.geanta@...escale.com>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>, <ruchika.gupta@...escale.com>,
	<NiteshNarayanLal@...escale.com>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <jinyanjiang@...il.com>
Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings

On 03/04/2015 06:57 AM, yjin wrote:
> An alternative is moving the definitions to a ".c" file, but I don't
> think it will be fundamental different.
> I know I am fixing a potential error which doesn't exist now, it seems
> useless for the current upstream version, we can abandon my patch. But I
> still think the current implementation adds unnecessary restrictions for
> its users.

I think that both dma_map_sg_chained and dma_unmap_sg_chained should go
away. They were added to support chained scatterlists, but as far as I
verified, dma_map_sg should handle that case as well.

Kim, can you confirm this?

Cristian S.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/