linux-kernel - Re: [PATCH] phy: berlin-usb: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150304091411.GA3001@kwain>
Date:	Wed, 4 Mar 2015 10:14:11 +0100
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: berlin-usb: Use PTR_ERR_OR_ZERO

On Sun, Mar 01, 2015 at 10:31:34PM +0800, Axel Lin wrote:
> PTR_ERR_OR_ZERO simplifies the code.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

> ---
>  drivers/phy/phy-berlin-usb.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index c8a8d53..9f7cc7e 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -202,10 +202,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
>  
>  	phy_provider =
>  		devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate);
> -	if (IS_ERR(phy_provider))
> -		return PTR_ERR(phy_provider);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(phy_provider);
>  }
>  
>  static struct platform_driver phy_berlin_usb_driver = {
> -- 
> 1.9.1
> 
> 
> 

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/