linux-kernel - Re: [PATCH -next] cpuset: initialize cpuset a bit early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVM=m6QmCSs5y2aR=V1K+Wtg1bE6ygftbHg_yaPJk+hUAw@mail.gmail.com>
Date:	Wed, 4 Mar 2015 17:19:42 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Zefan Li <lizefan@...wei.com>
Cc:	Tejun Heo <tj@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>,
	Vladimir Davydov <vdavydov@...allels.com>
Subject: Re: [PATCH -next] cpuset: initialize cpuset a bit early

On Wed, Mar 4, 2015 at 5:09 PM, Zefan Li <lizefan@...wei.com> wrote:
> Now we call ss->bind() in cgroup_init(), so cgroup_init() will
> call cpuset_bind() and then the latter will access top_cpuset's
> cpumask, which is NULL, because cpuset_init() is called after
> cgroup_init()
>
> The simplest fix is to swap cgroup_init() and cpuset_init().
>
> Cc: Vladimir Davydov <vdavydov@...allels.com>
> Fixes: 295458e67284 ("cgroup: call cgroup_subsys->bind on cgroup subsys initialization")
> Reported by: Ming Lei <tom.leiming@...il.com>
> Signed-off-by: Zefan Li <lizefan@...wei.com>

Looks this patch does fix the boot issue.

> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 61b9937..50d1e95 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -667,8 +667,8 @@ asmlinkage __visible void __init start_kernel(void)
>         page_writeback_init();
>         proc_root_init();
>         nsfs_init();
> -       cgroup_init();
>         cpuset_init();
> +       cgroup_init();
>         taskstats_init_early();
>         delayacct_init();
>
> --
> 1.8.0.2
>


Thanks
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/